Tests: Add blake2b Test Cases

[0xFFFC0000]

	* New files for blake2b test and testvector.
	* Adding the test to CMakeLists.txt
	* Adding brief documentation for the test.

Link to bounty:
https://bounties.monero.social/posts/75/6-500m-blake2b-c-dev-challenge-seraphis

[selsta]

Thank you.

I think this should be added to the hash tests, no need for a whole new binary.

Also please add trailing new lines so that GitHub doesn't complain and change the commit title to something like "tests: add blake2b test cases" to be more inline with other commits.

[0xFFFC0000]

Thanks.

Actually I considered adding it into the hash test, but the reason why I went with the new binary is that bounty specifically asks for a new blake2b_test.cpp file.

[0xFFFC0000]

Commit message and No trailing newline (editor issue) fixed.

[UkoeHB]

tests/hash works too

[0xFFFC0000]

I changed the commit and added the test logic to tests/main.cpp.

[UkoeHB]

Looking closer at the distinction between tests/crypto and tests/hash, I agree with @selsta that tests/hash would be more appropriate.

[0xFFFC0000]

Looking closer at the distinction between tests/crypto and tests/hash, I agree with @selsta that tests/hash would be more appropriate.

Will change the PR to tests/hash.

[0xFFFC0000]

@selsta @UkoeHB thanks for your feedback.

Changed the test location to tests/hash folder and integrated it into the existing test suite.

ctest -R hash-blake2b

[selsta]

A couple small comments.

[UkoeHB]

Suggested change

	static void hash_blake2b(const void *data, size_t length, char *key_out){
	// key_out is two buffer, first portion is key, second portion is out
	return (void) blake2b(key_out + BLAKE2B_KEYBYTES, BLAKE2B_OUTBYTES, data, length, key_out, BLAKE2B_KEYBYTES);
	}
	static void hash_blake2b(const void *data, size_t length, char *hash_out){
	// data = key || hash data
	return (void) blake2b(hash_out, BLAKE2B_OUTBYTES, data + BLAKE2B_KEYBYTES, length, data, BLAKE2B_KEYBYTES);
	}

The key_out is an out-param, it should not contain input data.

[UkoeHB]

LGTM, I need to check the test vector data then will approve.

[UkoeHB]

The test data is identical to the expected vectors.

[0xFFFC0000]

@UkoeHB @jeffro256 @selsta Thanks everyone for reviewing this. This is my first PR to the Monero repository and I am planning to send more PR regularly.

After @UkoeHB approval, I think at this point I am waiting for final approval.

[jeffro256]

The test data is identical to the expected vectors.

Yup, it's the same file

[UkoeHB]

I confirmed locally that the test vectors are being tested properly.

[0xFFFC0000]

[ RUN ] select_outputs.density /home/runner/work/monero/monero/tests/unit_tests/output_selection.cpp:175: Failure Expected: (fabsf(selected_ratio - chain_ratio)) < (0.025f), actual: 0.0289887 vs 0.025 [ FAILED ] select_outputs.density (3142 ms)

1. Is this related to my PR?
2. Does this happen in other cases too?

[UkoeHB]

@0xFFFC0000 that is a statistical test that fails periodically, not related to this PR.

[0xFFFC0000]

@UkoeHB thanks.