depends: use macOS 11 SDK with libc++ headers #8933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For context this is the issue that shows a RandomX related error on 10.12 and 10.13: #8504 Though we haven't received any more reports about this so I'm not sure if the issue got somehow fixed or if there simply are not a lot of macOS 10.13 or earlier users. |
vtnerd
approved these changes
Jul 27, 2023
selsta
approved these changes
Oct 24, 2023
tobtoht
force-pushed
the
macos_sdk_bump
branch
from
e6f1361
to
ebb7671
Compare
selsta
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #8929.
Our current SDK is missing libc++ headers and instead uses whichever headers are included in the binary clang package downloaded in depends, which we can't use with bootstrappable builds.
Considering that macOS 10.14 has already been EOL for almost two years and according to selsta: "monero doesn't run on 10.8 anyway i think. iirc 10.13 or 10.14 is the last working.", it should not be an issue to bump the minimum OSX version.
Edit: lowered minimum OSX version to 10.13.
Builds are passing, but not yet tested.
How to reproduce this SDK
Download XCode 12.2 from Apple (account required) or archive.org.
Follow the instructions here to create an SDK tarball that includes libc++ headers.
The sha256sum of the SDK should match:
df75d30ecafc429e905134333aeae56ac65fac67cb4182622398fd717df77619.