Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet2: fix store_to() and change_password() [RELEASE] #8938

Merged
merged 1 commit into from Sep 15, 2023
Merged

wallet2: fix store_to() and change_password() [RELEASE] #8938

merged 1 commit into from Sep 15, 2023

Conversation

jeffro256
Copy link
Contributor

@jeffro256 jeffro256 changed the title wallet2: fix store_to() [RELEASE] wallet2: fix store_to() and change_password() [RELEASE] Jul 10, 2023
@woodser
Copy link
Contributor

woodser commented Aug 21, 2023

@jeffro256 Can you please rebase on the release-v0.18 branch?

@jeffro256
wallet2: fix store_to() and change_password()
ba98269 
Resolves monero-project#8932 and:
2. Not storing cache when new path is different from old in `store_to()` and
3. Detecting same path when new path contains entire string of old path in `store_to()` and
4. Changing your password / decrypting your keys (in this method or others) and providing a bad original password and getting no error and
5. Changing your password and storing to a new file
@jeffro256
Copy link
Contributor Author

Okay it is rebased now

@luigi1111 luigi1111 merged commit 61e664a into monero-project:release-v0.18 Sep 15, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selsta selsta selsta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeffro256 @woodser @selsta @luigi1111