epee binary: container can read from empty seq of any type #8940
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vtnerd does your new wire reading code safety accept any type marker for empty sequences without error? |
|
These tests should still work with the new serialization engine. The inner type is only checked when processing that first element. |
vtnerd
approved these changes
Feb 16, 2024
jeffro256
force-pushed
the
test_epee_bin_any_empty_seq
branch
from
f42f9a8
to
48b7d08
Compare
rbrunner7
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good news: this property holds for current epee binary code in core repo. For real world example of issue brought on if this property is not upheld: monero-rs/monero-epee-bin-serde#49