wallet: feature: transfer amount with fee included [RELEASE] #8945
Conversation
|
Does this feature really need to be ported to the stable release branch? |
|
Why wouldn't it be? It's a useful feature. Are you saying it hasn't been reviewed enough? (True, it hasn't, but then we just don't approve it yet) |
|
In many projects, new features are not ported to an existing release branch to keep it stable. So I'm asking whether its worth breaking the possible stability of the current release branch for this feature. |
|
Having it on a stable release branch allows me to pull and test the feature against my library test suites and even release experimental features ahead of monero-project, whereas I'm not able to do that against master due to incompatibilities and the possibility of unreleased bugs. |
jeffro256
force-pushed
the
subtract_fee_from_outputs_18
branch
2 times, most recently
from
6987981
to
cb2df5d
Compare
|
Putting this PR in draft mode b/c I don't want it to be merged yet |
jeffro256
force-pushed
the
subtract_fee_from_outputs_18
branch
from
cb2df5d
to
d1d77d6
Compare
jeffro256
force-pushed
the
subtract_fee_from_outputs_18
branch
from
d1d77d6
to
baa4756
Compare
To transfer ~5 XMR to an address such that your balance drops by exactly 5 XMR, provide a `subtractfeefrom` flag to the `transfer` command. For example:
transfer 76bDHojqFYiFCCYYtzTveJ8oFtmpNp3X1TgV2oKP7rHmZyFK1RvyE4r8vsJzf7SyNohMnbKT9wbcD3XUTgsZLX8LU5JBCfm 5 subtractfeefrom=all
If my walet balance was exactly 30 XMR before this transaction, it will be exactly 25 XMR afterwards and the destination address will receive slightly
less than 5 XMR. You can manually select which destinations fund the transaction fee and which ones do not by providing the destination index.
For example:
transfer 75sr8AAr... 3 74M7W4eg... 4 7AbWqDZ6... 5 subtractfeefrom=0,2
This will drop your balance by exactly 12 XMR including fees and will spread the fee cost proportionally (3:5 ratio) over destinations with addresses
`75sr8AAr...` and `7AbWqDZ6...`, respectively.
Disclaimer: This feature was paid for by @LocalMonero.
jeffro256
force-pushed
the
subtract_fee_from_outputs_18
branch
from
baa4756
to
51d7a69
Compare
#8861