cmake: require sodium #9004
Merged
cmake: require sodium #9004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnerd
reviewed
Oct 7, 2023
| if(SODIUM_LIBRARY) | ||
| set(ZMQ_LIB "${ZMQ_LIB};${SODIUM_LIBRARY}") | ||
| if(Sodium_FOUND) | ||
| set(ZMQ_LIB "${ZMQ_LIB};${sodium_LIBRARIES}") |
There was a problem hiding this comment.
The documentation does not mention this variable name.
There was a problem hiding this comment.
Oh nevermind, its clearly in the CMake files.
vtnerd
approved these changes
Oct 7, 2023
| if(SODIUM_LIBRARY) | ||
| set(ZMQ_LIB "${ZMQ_LIB};${SODIUM_LIBRARY}") | ||
| if(Sodium_FOUND) | ||
| set(ZMQ_LIB "${ZMQ_LIB};${sodium_LIBRARIES}") |
There was a problem hiding this comment.
Oh nevermind, its clearly in the CMake files.
tobtoht
force-pushed
the
sodium_packages
branch
from
7020f87
to
cdab0d4
Compare
selsta
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not an optional dependency. Makes sure static libraries are used for static builds.