Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet2: fix on_reorg callback location #9006

Merged
merged 1 commit into from Feb 24, 2024

Conversation

j-berman
Copy link
Collaborator

Calls the on_reorg callback inside handle_reorg, instead of inside detach_blockchain.

detach_blockchain can be called even where there isn't a reorg (see how scan_tx uses detach_blockchain). handle_reorg should be called every time there is a reorg.

@selsta
Copy link
Collaborator

selsta commented Sep 27, 2023

Is this relevant for release branch?

@j-berman
Copy link
Collaborator Author

The on_reorg callback hasn't been added on the release branch yet. Opened #9008 for release (didn't see a PR for it).

@luigi1111 luigi1111 merged commit 2dc9184 into monero-project:master Feb 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants