CMake: only set policy CMP0148 to OLD if version >= 3.27 #9126
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How did my patch pass CI.. Anyway, Edit: Where is Ubuntu 20.04 CI getting CMake 3.28.1 from? It installs 3.16. |
0xFFFC0000
reviewed
Jan 19, 2024
CMakeLists.txt
Outdated
| @@ -40,8 +40,9 @@ include(CheckCXXCompilerFlag) | |||
| include(CheckLinkerFlag) | |||
| include(CheckLibraryExists) | |||
| include(CheckFunctionExists) | |||
|
|
|||
| cmake_policy(SET CMP0148 OLD) | |||
| if (NOT("${CMAKE_VERSION}" VERSION_LESS 3.27)) # If CMake version >= 3.27 | |||
There was a problem hiding this comment.
if(POLICY CMP0148)
cmake_policy(SET CMP0148 OLD) # https://cmake.org/cmake/help/latest/policy/CMP0148.html
endif()
It is a cleaner syntax IMHO [1].
The build shows that CMake is 3.27.8. https://github.com/monero-project/monero/actions/runs/6991078601/job/19021248770#step:9:25 This is a question for me too, where does our CI get 3.27.8. |
|
@0xFFFC0000 CI VM has it pre-installed, see #9128 |
Thanks. Now it makes sense. |
jeffro256
force-pushed
the
fix_cmake_policy_0148
branch
from
694105e
to
7e442c2
Compare
Co-authored-by: 0xFFFC0000 <0xFFFC0000@proton.me>
jeffro256
force-pushed
the
fix_cmake_policy_0148
branch
from
7e442c2
to
e7629dc
Compare
selsta
approved these changes
Jan 19, 2024
tobtoht
approved these changes
Jan 19, 2024
0xFFFC0000
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows people to compile if their CMake is older than 3.27
@tobtoht