Disable/fix ports with I2P #9138
Merged
+52
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just marked this as ready for review, and force pushed one last fix. I confirmed that: (1) i2p has no field for port when configuring a tunnel, (2) that multiple instances of an address appear with different port numbers, (3) that this patch "collapses" on address where port 1 is used as a placeholder. Unfortunately both the p2p protocol and storage mechanism will continue to read/write port for backwards compatibility. This is trivial as its only a 16-bit integer. |
|
Force pushed a change to improve backwards compatibility. |
iamamyth
reviewed
Jan 30, 2024
|
Updated the comment about returning |
iamamyth
approved these changes
Jan 31, 2024
|
built master with this yesterday, everything seems ok. just have a question, does this have any effect or change the docs for i2p https://github.com/monero-project/monero/blob/master/docs/ANONYMITY_NETWORKS.md ? stats/info: |
|
Yes, looks like the documentation needs to be updated to omit the port number with I2P. Will do that (hopefully today). |
selsta
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #8918 , but I am soliciting for tests before marking this as ready. Basically, I only know this passes the unit tests at this point.
The patch is pretty simple, I2P ports are now fixed at
0, so opening the new pearliest manager should collapse the overloads on port once it goes into the internal map.