Fix/aligned test 0.18 #9144
Closed
Fix/aligned test 0.18 #9144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the fix, it processed all transactions in the mempool which could be very slow when mempool grows to several MBs in size. I observed `get_block_template_backlog` taking up to 15 seconds of CPU time under high mempool load. After the fix, only transactions that can potentially be mined in the next block will be processed (a bit more than the current block median weight).
- BP+ support added for Trezor - old Trezor firmware version support removed, code cleanup
8cc3c9a Publish submitted txs via zmq (j-berman)
c0f3c5b Fix use of rtxn without a mdb_txn_safe wrapper (Howard Chu)
2b83d00 ledger support for hf 15 (BP+, view tags) (j-berman)
6075be9 feat(trezor): add HF15 support, BP+ (Dusan Klinec)
099fc1f Fixed get_block_template_backlog performance (SChernykh)
309f6ba build: prepare v0.18.1.0 (selsta)
265d6ca device: set ledger min app version (selsta)
fac7c43 continue pool pruning even if a tx can't be found (j-berman)
1287074 randomx: update submodule (selsta)
876c08d Bump Gitian build instructions to v0.18.1.0 [Release Branch] (Seth For Privacy)
- spend secret key is no longer the sum of multisig key shares; no need to check that is the case upon restore. - restoring a multisig wallet from multisig info means that the wallet must have already completed all setup rounds. Upon restore, set the number of rounds completed accordingly.
- only allow offline wallets to import outputs - don't import empty outputs - export subaddress indexes when exporting outputs
Co-authored-by: woodser <woodser@protonmail.com>
Ensures both transfers and sweeps use a fee that's calculated from the tx's weight. Using different logic could theoretically enable distinguishability between the two types of txs. We don't want that.
Header was using `uint64_t` without including `<cstdint>` which caused some issues downstream for windows builds
Accessing an object of type `char` thru an lvalue of type `crypto::hash8` is undefined behavior. https://developers.redhat.com/blog/2020/06/03/the-joys-and-perils-of-aliasing-in-c-and-c-part-2
0c04018 depends: openssl: update to 3.0.11 (tobtoht)
e0b2123 http_client: reduce number of packets sent for small bodies (jeffro256)
bdebf68 wallet2: ensure transfers and sweeps use same fee calc logic (j-berman)
09a88cc Update RandomX to 1.2.1 (tevador)
Multisig keys per-transfer were being wiped, but not erased, which lead to a ginormous quadratic bloat the more transfers and exports you performed with the wallet.
- Fixed uninitialized `state->x` warning - Fixed broken code with `-O3` or `-Ofast` The old code is known to break GCC 10.1 and GCC 11.4
5b0c274 gitian: add riscv64 support (selsta)
14ae812 cryptonote_config: include cstdint (jeffro256)
eae62a0 ringct: make ctSigBase serialization follow strict aliasing rule (jeffro256)
0f75585 multisig: better errors for small malformed kex msgs (jeffro256)
e7d51e5 JH hash compiler workarounds (SChernykh)
5435202 readline_buffer: disable bracketed paste escape sequences (Jeffrey Ryan)
6c38c21 heed NO_COLOR environment variable (moneromooo-monero)
fe47806 wallet: fix multisig key memory leak (jeffro256)
fe746dc Fix EAGAIN bug in ZMQ-RPC/ZMQ-PUB (Lee *!* Clagett)
47d8899 Fix missing checks for IsObject in ZMQ jsonrpc reading (Lee Clagett)
|
Oops, wrong patch, lets retry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #9142 but on release branch.