Add --no-sync-pruned-blocks, and enable syncing pruned blocks by default for pruned nodes #9180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expiredhotdog
changed the title
expiredhotdog
commented
Feb 19, 2024
expiredhotdog
force-pushed
the
master
branch
from
36cb71a
to
65ddb40
Compare
selsta
reviewed
Feb 21, 2024
There was a problem hiding this comment.
What do you think about changing
const command_line::arg_descriptor<bool> arg_sync_pruned_blocks = {
to
const command_line::arg_descriptor<unit64_t> arg_sync_pruned_blocks = {
and then setting it to 1 as default value. Then someone who wants to disable it can do --sync-pruned-blocks 0 and we don't have to add another flag. See the --fast-block-sync flag as an example that works this way.
expiredhotdog
force-pushed
the
master
branch
from
4e7847a
to
d80c526
Compare
|
@selsta This change was modeled after #3191, with the intent of doing the same as #8855 at some point in the future. The reasoning for adding --no-fluffy-blocks at the time was to avoid breaking anyone's scripts, which I somewhat agree with. I'm happy to change it if you think the unit64_t version would be better, though. |
extra sanity checking update autocomplete simplify
expiredhotdog
force-pushed
the
master
branch
from
1dfd919
to
e441a94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8834.
Edit: closed because this got needlessly messy