Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Links #9185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

@selsta
Copy link
Collaborator

selsta commented Feb 20, 2024

Please squash your commits and use a proper commit title like Doxygen: fix broken links.

@justindhillon
Copy link
Author

@selsta , It has been squashed!

@selsta
Copy link
Collaborator

selsta commented Feb 21, 2024

Doesn't appear to be fully squashed, there is still the "Merge branch 'monero-project:master' into master" commit. You probably need a git desktop client for it, GitHub web interface doesn't work.

@jeffro256
Copy link
Contributor

run git rebase -i master and change the second line from pick ... to squash ...

@justindhillon
Copy link
Author

I eventually figured it out. It is now one commit.

@@ -981,7 +981,7 @@ HTML_INDEX_NUM_ENTRIES = 100
# directory and running "make install" will install the docset in
# ~/Library/Developer/Shared/Documentation/DocSets so that Xcode will find
# it at startup.
# See https://developer.apple.com/tools/creatingdocsetswithdoxygen.html
# See https://developer.apple.com/xcode/resources/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn't actually lead to any useful information, just the Xcode home doc page. I agree that the OG link is broken, but this new link isn't useful either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants