serialization: free function DSL #9195
Merged
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffro256
changed the title
jeffro256
added a commit
to jeffro256/monero
that referenced
this pull request
Feb 21, 2024
Use free functions to do serialization in-place. Simplifies code, reduces binary size, and reduces copying. Depends on monero-project#9195 and monero-project#9194
0xFFFC0000
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
LGTM.
If you add a comment to your PR first post with an example, that would make it much better. I followed the discussion in Koe's repo, and these comments [1] look nice. Maybe a shorter version of these comments, in the commit message or your PR page would improve it.
The case I am thinking about is: that later when someone runs a git-blame or looks at this PR page, comments/explanations should be obvious.
Example usage for Seraphis types (in global or `sp` namespace):
```
BEGIN_SERIALIZE_OBJECT_FN(sp::SpCoinbaseEnoteCore)
FIELD_F(onetime_address)
VARINT_FIELD_F(amount)
END_SERIALIZE()
BEGIN_SERIALIZE_OBJECT_FN(sp::SpEnoteCore)
FIELD_F(onetime_address)
FIELD_F(amount_commitment)
END_SERIALIZE()
```
jeffro256
force-pushed
the
free_function_serial_mas
branch
from
3c46a56
to
2a2da79
Compare
0xFFFC0000
approved these changes
Feb 24, 2024
jeffro256
added a commit
to jeffro256/monero
that referenced
this pull request
Feb 29, 2024
Use free functions to do serialization in-place. Simplifies code, reduces binary size, and reduces copying. Depends on monero-project#9195 and monero-project#9194
jeffro256
added a commit
to jeffro256/monero
that referenced
this pull request
Mar 2, 2024
Okay I promise after this and the BulletproofPlus2Proof PR I'll stop bitching about the tx class format. * Replace `rct::clsag` with `LegacyClsagProof`, which is `rct::clsag` without `I` field * Remove bin config fields and generator seed from `SpMembershipProofV1` * Add `SemanticConfigSpRefSetV1 get_sp_ref_set_config(tx_version_t)` method to `TxValidationContext` * Add `validate_tx_sp_ref_set_semantics` validator impl free function * Add `tx_version_from(const SpTxType&)` validator impl free function * Make `TxValidationContextMock` bound to a specific `SemanticConfigSpRefSetV1` * Direct serialization Depends on monero-project#9195 and monero-project#9194
jeffro256
added a commit
to jeffro256/monero
that referenced
this pull request
Mar 4, 2024
Okay I promise after this and the BulletproofPlus2Proof PR I'll stop bitching about the tx class format. * Replace `rct::clsag` with `LegacyClsagProof`, which is `rct::clsag` without `I` field * Remove bin config fields and generator seed from `SpMembershipProofV1` * Add `SemanticConfigSpRefSetV1 get_sp_ref_set_config(tx_version_t)` method to `TxValidationContext` * Add `validate_tx_sp_ref_set_semantics` validator impl free function * Add `tx_version_from(const SpTxType&)` validator impl free function * Make `TxValidationContextMock` bound to a specific `SemanticConfigSpRefSetV1` * Direct serialization Depends on monero-project#9195 and monero-project#9194
UkoeHB
approved these changes
Mar 5, 2024
jeffro256
added a commit
to jeffro256/monero
that referenced
this pull request
Mar 7, 2024
Okay I promise after this and the BulletproofPlus2Proof PR I'll stop bitching about the tx class format. * Replace `rct::clsag` with `LegacyClsagProof`, which is `rct::clsag` without `I` field * Remove bin config fields and generator seed from `SpMembershipProofV1` * Add `SemanticConfigSpRefSetV1 get_sp_ref_set_config(tx_version_t)` method to `TxValidationContext` * Add `validate_tx_sp_ref_set_semantics` validator impl free function * Add `tx_version_from(const SpTxType&)` validator impl free function * Make `TxValidationContextMock` bound to a specific `SemanticConfigSpRefSetV1` * Direct serialization Depends on monero-project#9195 and monero-project#9194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming UkoeHB#32