[seraphis] seraphis_crypto: add crypto utils #9196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| return MINUS_ONE; | ||
| } | ||
| //------------------------------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Where did you get the invert function from?
What are the requirements on the scalar so this operation works properly?
What would be the effect of inverting on clamped scalars?
Any comments on this phrase here?
In order to prevent attacks using small subgroups, the scalarmult functions above clear lower bits of the scalar. This may be indesirable to build protocols that requires n to be invertible.
There was a problem hiding this comment.
Where did you get the invert function from?
As I said in the PR comment "Some functions were taken from code written by Sarang:" "invert(): bulletproofs2.cpp"
jeffro256
reviewed
Feb 22, 2024
Co-authored-by: Jeffro <jeffreyryan@tutanota.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR in my 'upstreaming seraphis_lib project', the changes here are not used anywhere yet.
Adds a set of crypto utility functions. Some functions were taken from code written by Sarang:
invert(): bulletproofs2.cppdecompose(): triptych experimental branchkronecker_delta(): triptych experimental branchconvolve(): triptych experimental branchThese are security-critical functions.