[seraphis] crypto: add blake2b #9198
Open
+681
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UkoeHB
commented
Feb 22, 2024
| /// END: blake2-impl.h | ||
|
|
||
| void clear_internal_memory(void *mem, const size_t length) { | ||
| memwipe(mem, length); |
There was a problem hiding this comment.
Adding this memwipe is the main difference with the randomx version, which comments out all calls to clear_internal_memory().
UkoeHB
commented
Feb 22, 2024
src/crypto/blake2b.h
Outdated
Comment on lines
89
to
96
| // crypto namespace (fixes naming collisions with libsodium) | ||
| #define blake2b_init crypto_blake2b_init | ||
| #define blake2b_init_key crypto_blake2b_init_key | ||
| #define blake2b_init_param crypto_blake2b_init_param | ||
| #define blake2b_update crypto_blake2b_update | ||
| #define blake2b_final crypto_blake2b_final | ||
| #define blake2b crypto_blake2b | ||
| #define blake2b_long crypto_blake2b_long |
There was a problem hiding this comment.
Setting the namespace to crypto is the only other difference from randomx, which uses the randomx namespace.
|
Could you please revert whitespace diffs from the RandomX Blake2b file? |
@jeffro256 done, looks like someone in the history of these files was not using spaces for tabs... |
jeffro256
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR in my 'upstreaming seraphis_lib project', the changes here are not used anywhere yet.
src/crypto. The code is lifted almost verbatim from randomx.src/crypto/blake2b.h. Test withctest -R hash-blake2bin thetests/hashfolder in your build directory.