New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depends: {native_,}protobuf: speedup build #9199

Open

tobtoht wants to merge 2 commits into monero-project:master from tobtoht:depends_pb_speedup

Contributor

tobtoht commented Feb 23, 2024

install-libLTLIBRARIES triggers builds for libprotoc.a and libprotobuf-lite.a, which we don't need.
The make jobserver isn't available in stage_cmds, making this slower than necessary.
This PR reduces build time to ~39s (for native_protobuf + protobuf) down from 1:50 on my machine.
Forces Trezor support for depends builds to prevent a silent regression.

tobtoht added 2 commits

February 23, 2024 10:56


          build: force Trezor for depends builds

3c16794


          depends: {native_,}protobuf: speedup build

5fdd67d

tobtoht mentioned this pull request

Bootstrappable Builds #8929

Open

22 tasks

selsta added the build system label

tobtoht mentioned this pull request

build: force Trezor for depends builds [release] #9291

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment