depends: native_libtapi: don't embed git hash #9204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selsta
approved these changes
Feb 26, 2024
hyc
reviewed
Feb 26, 2024
tobtoht
force-pushed
the
depends_libtapi_repro
branch
from
0809f99
to
358d27c
Compare
hyc
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
native_libtapidepends package is not reproducible because it embeds the checked out git hash of whatever git repository it happens to have been extracted to, which is that of the monero repo in our case. If thenative_libtapipackage is cached, runs for different monero commits that otherwise do not invalidate the cache will use anative_libtapipackage with a hash that does not match the hash of a clean build.This does not make its way into release binaries, but hinders automated reproducibility scanning.