wallet2: move wallet error on RPC resp handling to wallet_errors file #9380
+32
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnerd
suggested changes
Jun 25, 2024
src/wallet/wallet_errors.h
Outdated
| { | ||
| namespace error | ||
| { | ||
| static inline void throw_on_rpc_response_error(bool r, const epee::json_rpc::error &error, const std::string &status, const char *method) |
There was a problem hiding this comment.
Again, I would drop the static keyword here. This one should arguably be in a cpp anyway.
Co-authored-by: jeffro256 <jeffro256@tutanota.com>
j-berman
force-pushed
the
wallet-errs-org
branch
from
d3def4d
to
6c192f4
Compare
vtnerd
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports consistent RPC error response handling between wallet2 and a new wallet lib
Credit to @jeffro256 for identifying the source of a syntax issue
Used in the Seraphis lib async scanner: UkoeHB#23