Daemon RPC: /getblocks.bin return chain's top_block_hash in resp #9383
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnerd
approved these changes
Jun 25, 2024
src/cryptonote_core/blockchain.cpp
Outdated
| @@ -2774,7 +2774,10 @@ bool Blockchain::find_blockchain_supplement(const uint64_t req_start_block, cons | |||
| if(req_start_block > 0) | |||
| { | |||
| // if requested height is higher than our chain, return false -- we can't help | |||
| if (req_start_block >= m_db->height()) | |||
| uint64_t top_height; | |||
There was a problem hiding this comment.
Nitpick, but you really don't need the temporary top_height here or below. Just give total_height to top_block_hash then ++total_height.
j-berman
force-pushed
the
getblocks-top-block-hash
branch
from
7a6ac29
to
9f83e74
Compare
vtnerd
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particularly useful in combination with #9382, so that the client can be certain it's on the correct chain even when the request to /getblocks.bin includes a
start_height > chain tipUsed in the Seraphis lib async scanner: UkoeHB#23