src: add net type and daemon address to wallet rpc #9406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selsta
reviewed
Jul 26, 2024
|
@selsta I've increased WALLET_RPC_VERSION_MINOR from 27 to 28 |
|
Please squash two commits. And push it as a same commit. |
D3vN1
force-pushed
the
dev/d3vn1/add-url-and-nettype-wallet-rpc
branch
from
dbcbb78
to
56ca0a3
Compare
|
I have successfully squashed the two commits and pushed them as a single commit, as per your request. |
|
Why do clients need to know this info? |
iamamyth
reviewed
Jul 30, 2024
| { | ||
| std::string daemon_address; | ||
| std::string nettype; | ||
| bool mainnet; |
There was a problem hiding this comment.
It rarely makes sense to include outputs of pure functions of response data in a response; exceptions can be made in case of complicated functions, but these boolean values are all trivially derived from the nettype (as can be seen by the code which sets them).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8524