Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for view tags in next hf #266

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

j-berman
Copy link
Contributor

At the next hard fork, wallets will construct tx's where each output has a "view tag" stored on it. It's meant to speed up wallet scanning :) More on it here: monero-project/monero#8061

The smoothest way I could see how to add view tags to outputs in the core repo was by creating a new output type, which I called txout_to_tagged_key (after the fork, txout_to_key types won't be allowed anymore). This PR is necessary because of that change, unfortunately. To make the change as clean as I could, I added a helper function get_output_public_key to the core repo, so you can see in this PR the caller doesn't actually need to know the output type. I got rid of all txout_to_key types used in this repo and replaced with that helper function.

Hope you like! :)

@moneroexamples
Copy link
Owner

Thank you for your work on the tags and the PR to the explorer. Greatly appreciated.

@moneroexamples moneroexamples merged commit a6bb81b into moneroexamples:devel Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants