Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the next hard fork, wallets will construct tx's where each output has a "view tag" stored on it. It's meant to speed up wallet scanning :) More on it here: monero-project/monero#8061
The smoothest way I could see how to add view tags to outputs in the core repo was by creating a new output type, which I called
txout_to_tagged_key
(after the fork,txout_to_key
types won't be allowed anymore). This PR is necessary because of that change, unfortunately. To make the change as clean as I could, I added a helper functionget_output_public_key
to the core repo, so you can see in this PR the caller doesn't actually need to know the output type. I got rid of alltxout_to_key
types used in this repo and replaced with that helper function.Hope you like! :)