-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Styling #53
Additional Styling #53
Conversation
Sweet! Let me know when its up! Excited to see it with real data.
…On Sat, Apr 15, 2017 at 5:49 PM moneroexamples ***@***.***> wrote:
Merged #53
<#53>
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHf02QhTpm_OS2RR4hBvXjmjD6y0QYktks5rwUmHgaJpZM4M-drS>
.
|
It is already up. I made one comment also, but cant find it now. Maybe didnt save it. Anyway I write again. Thanks for PRs. The new changes are already live: http://139.162.32.245:8081/ First impressions are good. I like the input fields and blue button. Not sure about the table borders though. On block page (e.g., http://139.162.32.245:8081/block/1289479) there is not much text anyway, and table borders seem to dominate over the text. Also regarding the tables. In tor browser (http://libwh5lvouddzei4.onion/) the index page is too wide now. I think the framework made the table too wide and not adapt well to tor browser width. In comparison, this is older instance of the onion explorer (http://dvwae436pd7nt4bc.onion/). It fits better to tor browser width, even though it has one extra column (rct/type), as compared to the current version. In the current version this column was removed to made the index page width agree even better with tor browser. Thus need to check why this framework made the index page so wide. |
@moneroexamples I can take out some of tables on the block page, agree it's a bit heavy. I'm also looking at some other frameworks including https://picnicss.com/ which has better out-of-the-box styling/components. Using picnic would probably entail a complete re-design. It even has nice tabs (https://picnicss.com/documentation#tabs) and other helpful, pretty components. The reason I initially went with pure-css is because it easily fits into your existing css, but I don't think this will be the case with picnic (which is a good and bad thing). I've been developing "blind" because I can't get the actual back=end to run based on #54 (and probably a lack of trying), but I'm happy to try harder so that I can build a better UI for the site while having access to a dev environment. |
What kind of errors you get when building and what os? For building test branches (e.g. pure_css_try), you need latest development version of monero. If you can list compilation problems or issues I try helping out. All the examples are developed and tested on linux, so can help only with Linux compilations. Can't help much with windows or mac os unfortunately. |
Potential white version that @Gingeropolous may be interested in for xmrchain.net. Just need to apply your same CSS tweaks to invert the colors.