Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed mixin to ring size/ring member #60

Closed
wants to merge 1 commit into from
Closed

Changed mixin to ring size/ring member #60

wants to merge 1 commit into from

Conversation

ajs-xmr
Copy link
Contributor

@ajs-xmr ajs-xmr commented May 17, 2017

@moneroexamples
Copy link
Owner

Thanks. At the moment I can't merge it as its not that simple. ring size = mixin + 1, so by changing mixin to ring size on index page, for example, would result in incorrect information. So minimal changes in one or two places in C++ are needed as well.

If you want you can make these changes, and make PR for one of the development branches. For instance, the development server, http://139.162.32.245:8081/, is running this branch now for tests:

https://github.com/moneroexamples/onion-monero-blockchain-explorer/tree/emission_rate_thread

@ajs-xmr
Copy link
Contributor Author

ajs-xmr commented May 17, 2017

Okay. Will look in to it.

@moneroexamples
Copy link
Owner

Thanks. The changes needed are small. For example, in this line -1 should be removied:

https://github.com/moneroexamples/onion-monero-blockchain-explorer/blob/emission_rate_thread/src/page.h#L154

In general, just have to check where templates take mixin numbers from, and add or substract 1 from them. Please don't change variable names in C++. All explorer logic is in page.h.

@ajs-xmr
Copy link
Contributor Author

ajs-xmr commented May 19, 2017

Moved to development branch #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants