Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api version to get_version call #35

Closed
Jaqueeee opened this issue Jul 26, 2017 · 4 comments
Closed

Add api version to get_version call #35

Jaqueeee opened this issue Jul 26, 2017 · 4 comments

Comments

@Jaqueeee
Copy link
Contributor

Will be needed in future, when api gets updated. Ideally it should be aligned with mymonero api.
@vtnerd

@moneroexamples
Copy link
Owner

I can add it rpc api version to current get_version call. A api version number similar to CORE_RPC_VERSION in monero would be good i think?

@Jaqueeee
Copy link
Contributor Author

Yes. That's a great idea.

@moneroexamples
Copy link
Owner

I added tentatively the api version to upgrade_angularjs branch. It is already being displayed in the dev testnet version: http://139.162.32.245:81 . The versioning in the backend is based on CORE_RPC_VERSION stype, i.e.,

#define OPENMONERO_RPC_VERSION_MAJOR 1
#define OPENMONERO_RPC_VERSION_MINOR 0
#define MAKE_OPENMONERO_RPC_VERSION(major,minor) (((major)<<16)|(minor))
#define OPENMONERO_RPC_VERSION \
    MAKE_OPENMONERO_RPC_VERSION(OPENMONERO_RPC_VERSION_MAJOR, OPENMONERO_RPC_VERSION_MINOR)

@Jaqueeee
Copy link
Contributor Author

Thanks!

moneroexamples added a commit to moneroexamples/onion-monero-blockchain-explorer that referenced this issue Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants