Change "XMR" to global.config.general.coinCode in coin javascript

[bobbieltd]

In coin javascript, there are alot of hardcoded XMR log/email/text (mainly from Snipa's toriginal code), can you change all "XMR" to global.config.general.coinCode ?
I know it's not important. Just in case, you want to do it ;), great job !

[MoneroOcean]

OK. Will do it this week.

[MoneroOcean]

I must be blind but the only XMR hardcore in common code I found and fixed is here:

e45c946

[bobbieltd]

Never mind. It's minor issue, I can do by hand to change. For orphan leaf node, here is Venthos' solution. We only need to wait for block height pass that orphan block (+1), if blockManager still can't find by hash, we can store as orphan block (no need timer check) : Venthos@4dd98c1

[bobbieltd]

One more things, for pool module, he doesn't use updatetemplate every 300ms but he use getlasblockheader to check. It's less CPU usage --> more effective. What do you think ?

[MoneroOcean]

I think you should check my code. I use getlastblockheader for ages)

[MoneroOcean]

Ventos fix is simpler, but I would like to see how Snipa will react to it. There can be a problem if master node has block on that height already that will be actually orphaned (and not our block from leaf node). In this case we will end with wrong block reward.

[bobbieltd]

Not neccessary anymore. Close this issue.