feat: make applicatives compatible with fantasyland and ramda #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 19, 2017
|
@char0n - please make this PR against develop branch, not master ;) |
|
@ulfryk rebased. |
|
I'll try to release next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes monet.js applicatives compatible with fantasy-land spec 1.x.y, though making it compatible with next release of ramda. Pull request (ramda/ramda#1900) has been already merged to master to support this. If this pull request gets merged, then monet.js will finally be compatible with ramda (ap, liftN).
It is already possible to use ramda +monet using ramda-adjunct (https://char0n.github.io/ramda-adjunct/1.3.0/RA.html#.liftFN). ramda-adjunct will keep support the older versions of monet indefinetly.