Add NonNullable return type requirement for Maybe.map #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the typings file to be consistent with the javascript which prevents `null` values from being initialized within a `Maybe`. The `NonNullable` type requires TypeScript 2.8+. Additionally, the TS update brings better type coverage which caused one `NEL` test to fail and has been updated to reflect the correct type.
ulfryk
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the typings file to be consistent with the javascript which
prevents
nullvalues from being initialized within aMaybe.The
NonNullabletype requires TypeScript 2.8+.Additionally, the TS update brings better type coverage which caused one
NELtest to fail and has been updated to reflect the correct type.