Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Format dollar amounts using the Intl API. #1169

Closed
elliotcourant opened this issue Oct 31, 2022 · 0 comments · Fixed by #1213
Closed

feat(ui): Format dollar amounts using the Intl API. #1169

elliotcourant opened this issue Oct 31, 2022 · 0 comments · Fixed by #1213
Labels
enhancement New feature or request good first issue Good for newcomers ui Related to or caused by the React UI.

Comments

@elliotcourant
Copy link
Member

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat

https://formatjs.io/docs/react-intl/components/#formattednumber
@elliotcourant elliotcourant added enhancement New feature or request ui Related to or caused by the React UI. good first issue Good for newcomers labels Oct 31, 2022
@github-actions github-actions bot mentioned this issue Nov 26, 2022
Merged
elliotcourant added a commit that referenced this issue Dec 21, 2022
@elliotcourant
fix(ui): Fixed amount formatting for transactions view.
5702a3b 
The transactions view was not using the intl formatter that was being
used elsewhere in the UI. It has not been updated such that it will use
the intl formatter.

Related To #1169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers ui Related to or caused by the React UI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 0.12.4 monetr/monetr
1 participant
@elliotcourant