Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(makefile): Add check for pnpm #1492

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Conversation

fredrb
Copy link
Contributor

@fredrb fredrb commented Sep 9, 2023

When running make develop for the first time, I ran into an error where a install binary was being called.

This happens because I didn't have pnpm installed, resulting in $(PNPM) install resolving to install

$ make develop
install
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 file2
       install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 ... fileN directory
       install -d [-v] [-g group] [-m mode] [-o owner] directory ...
make: *** [/Users/fbittenc/go/src/github.com/monetr/monetr/node_modules] Error 64

I've added a check for pnpm in Makefile to show a proper error message when running make develop without pnpm, resulting in the following message:

$ make develop
Error: pnpm not found.
make: *** [check-pnpm] Error 1

I placed check-pnpm as a dependency of $(NODE_MODULES), which itself is a dependency of other steps. Let me know if you think there is a better step to add this in.

@elliotcourant
Copy link
Member

Thank you very much!

@elliotcourant
Copy link
Member

Once the build passes I'll merge, no need to worry about the mkdocs step; its trying to use the internal image.

@elliotcourant elliotcourant merged commit 434b143 into monetr:main Sep 9, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants