-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Map institutions between data providers #1665
Draft
elliotcourant
wants to merge
23
commits into
main
Choose a base branch
from
feature/inst-mapping
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elliotcourant
commented
Feb 4, 2024
- feat(api): Adding support for teller.io
- chore: More teller resources
- chore: Progress on resources
- chore: Id
- chore: More progress
- chore: PRogress on models and requests
- chore: Progress
- feat(api): Rewriting how secrets are stored.
- feat(api)!: Moving secrets to repository.
- chore: Cleaning up a lot of stuff
- chore: Progress
- chore: Fixing tests
- feat(api): Adding support for syncing with teller
- chore: breaking shit
- fix(api): Fixing teller API calls
- chore: Getting certificates working for local dev
- fix(api): Fix how teller parses dates
- chore: Getting teller sync working!
- chore: Adding command to import teller link
- chore: Fix pipeline
- chore: Fixing mistakes
- chore: Working on institution mapper
- feat(api): Working on building an institution mapping tool
Right now secrets were stored in a plaid tokens table and I was going to do something similar for teller. But it wasn't a great pattern and caused some weirdness with dependency cycles. Instead I'm going to store secrets in a separate table entirely. This table will store all secrets instead of just secrets of a certain type. And secrets will be scoped to a single account.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1665 +/- ##
==========================================
- Coverage 51.17% 48.50% -2.67%
==========================================
Files 338 351 +13
Lines 18050 19492 +1442
Branches 471 477 +6
==========================================
+ Hits 9237 9455 +218
- Misses 8297 9511 +1214
- Partials 516 526 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.