Skip to content

Commit

Permalink
also support activemodel 4
Browse files Browse the repository at this point in the history
  • Loading branch information
Phil Lee committed Aug 10, 2015
1 parent 549e2de commit e270f6e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion postcodeanywhere-emailvalidation.gemspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = '>= 1.9.3'

spec.add_dependency 'rest-client', '~> 1.6'
spec.add_dependency 'activemodel', '~> 3.2'
spec.add_dependency 'activemodel', '>= 3.2', '< 5'

This comment has been minimized.

Sign in to view

Copy link
@darokel

darokel Aug 10, 2015

Is capping necessary here?

This comment has been minimized.

Sign in to view

Copy link
@asmega

asmega Aug 10, 2015

Contributor

We don't support rails 5 at the moment

This comment has been minimized.

Sign in to view

Copy link
@darokel

darokel Aug 10, 2015

Sure. I think to go with consistency of how we version everything else, perhaps leave out the cap and let Bundler take care of it?

This comment has been minimized.

Sign in to view

Copy link
@asmega

asmega Aug 10, 2015

Contributor

I don't understand let Bundler take care of it?. so what do you suggest I change this line to?

This comment has been minimized.

Sign in to view

Copy link
@darokel

darokel Aug 10, 2015

Remove the cap

spec.add_development_dependency 'bundler', '~> 1.2'
spec.add_development_dependency 'capybara', '~> 2.1'
Expand Down

0 comments on commit e270f6e

Please sign in to comment.