Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend process for setting up environment #238

Merged
merged 2 commits into from Jan 16, 2019
Merged

Amend process for setting up environment #238

merged 2 commits into from Jan 16, 2019

Conversation

margOnline
Copy link
Contributor

@margOnline margOnline commented Jan 15, 2019 •
edited

I had a few issues when I first set up this repo and I was following the readme exactly. This pr updates the text accordingly and addresses a couple of small issues:

  1. no need to declare the attr_encrypted gem, DRY!
  2. the ATTR_CRYPT_KEY needs to be 32 bytes or it will cause alot of the tests to fail

MarcoBgn
MarcoBgn approved these changes Jan 16, 2019
View reviewed changes
Copy link

@MarcoBgn MarcoBgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @margo! Are we still using Travis on this project?

@margOnline
Copy link
Contributor Author

@MarcoBgn 🤷‍♀️

@margOnline margOnline merged commit 16b94e2 into master Jan 16, 2019
@margOnline margOnline deleted the update_readme branch January 16, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-stefano tomas-stefano tomas-stefano approved these changes

@rnalexander rnalexander rnalexander approved these changes

@MarcoBgn MarcoBgn MarcoBgn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@margOnline @tomas-stefano @rnalexander @MarcoBgn