WIP: update dependencies #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've updated everything besides bs58. The reason to not updated bs58 is that the 1.x version of bs58 used Buffers, and the 2.x version used ArrayBuffers. I'm not sure what the 3.x version uses, but it doesn't seem to work with fullnode, and almost certainly doesn't fix any fundamental bugs (because the algorithm used is not error-prone and passes a lot of tests in fullnode).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated all of the dependencies. Unfortunately the node tests now run in 15s rather than 3s on my machine, meaning something has changed dramatically for the worse. I'm not actually aware of any security vulnerabilities in any of the outdated dependencies I'm using, so I think I'll hold off on updating things for now since it makes things unacceptably slower.