Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to find transactions with not empty Notes or Number value #2043

Closed
vomikan opened this issue Feb 24, 2019 · 0 comments
Closed

How to find transactions with not empty Notes or Number value #2043

vomikan opened this issue Feb 24, 2019 · 0 comments
Labels
enhancement fixed
Milestone
v1.4.0

Comments

@vomikan
Copy link
Member

vomikan commented Feb 24, 2019 •
edited

https://forum.moneymanagerex.org/viewtopic.php?f=16&t=8093&p=17477#p17477

Current filter algorithm is using 'Contains' function. I suggest to replace with 'Matches'.

    else if (getNumberCheckBox() && getNumber() != tran.TRANSACTIONNUMBER)
        ok = false;
    else if (getNotesCheckBox() && !tran.NOTES.Lower().Contains(getNotes().Lower()))
        ok = false;
vomikan added a commit that referenced this issue Feb 25, 2019
@vomikan
Merge pull request #2056 from vomikan/#2043
30ee2ee 
fix(#2043): matches and empty notes and number
@vomikan vomikan closed this as completed Feb 25, 2019
@slodki slodki added the fixed label Feb 25, 2019
@slodki slodki added this to the v1.4.0 milestone Feb 25, 2019
@vomikan vomikan mentioned this issue Feb 9, 2020
Closed
vomikan added a commit that referenced this issue Apr 26, 2020
@vomikan
fix(v135): #2408 2403 #2043
d2344a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement fixed
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
2 participants
@slodki @vomikan