Account list loses focus when using keyboard navigation

[cmbarbu]

MMEX version:

• 1.5.1

Note: bug reporters are expected to have verified the bug still exists
either in the last stable version of MMEX or on updated development code
(master branch).

Operating System:

• Windows
• Mac OSX
• Linux

Description of the bug

It is not possible to navigate through the account list using the keyboard. After pressing "up" or "down" once, the focus moves to the ledger.

Reproduction

Is the bug reproducible?

• Always
• Randomly
• Happened only once

Reproduction steps:

1. Click on any account in the navigation pane
2. Use keyboard navigation to move up or down in the list
3. After key up, the navigation pane loses focus

Expected result: The previous / next account in the list is selected and gets focus.

Actual result: The previous / next account in the list is selected, but the navigation pane loses focus. Subsequent presses of the "up" or "down" keys will select transactions in the ledger.

Additional information

[vomikan]

#3194

[2BeeOrNot]

This issue has be tagged as fixed. Has it been fixed for macOS? Using the up and down arrows in the navigation panel doesn't work at all in latest nightly built on May 9 2921 07:08:41. Same for latest build from Mark built on May 8. Previous nightly built on May 7 and Mark's May 7 build works as described as above.

[vomikan]

@whalley please assist

[whalley]

Think the mmGUIFrame::OnKeyPressed(wxTreeEvent& event) needs an event.Skip(); at the end otherwise the up/down keys are not going to processed. But I'm intrigued as to why you needed to add the OnKeyPressed method anyway as the removal of the SetFocus() calls alone seems to solve the reported problem.

Was the key handling added for something to do with the Transaction report dialog?

[vomikan]

Sometimes (even often) a good solution should be ripen.
And Yes. The Enter button allows you to reactivate the report.

[whalley]

Just spotted that keyboard navigation in the transaction list is now broken!

[whalley]

Pressing any key gives no response. Running in debug mode I get wxWidgets errors, e.g. pressing up arrow I get:

10:17:46: Debug: Unrecognised keycode 377
10:17:46: Debug: Unrecognised keycode 379
10:17:46: Debug: Unrecognised keycode 376
10:17:46: Debug: Unrecognised keycode 378
10:17:46: Debug: Unrecognised keycode 381
10:17:46: Debug: Unrecognised keycode 380
10:17:46: Debug: Unrecognised keycode 375
10:17:46: Debug: Unrecognised keycode 382
10:17:46: Debug: Unrecognised keycode 370
10:17:46: Debug: Unrecognised keycode 368

It seems to being generated from here: https://github.com/wxWidgets/wxWidgets/blob/master/src/osx/carbon/app.cpp

So looks like it may be MacOS specific. Not sure if this Locale related or related to the fixes here? Will need to back track to last build that this worked in and then look at changes.

[2BeeOrNot]

Works for me on macOS 10.15.7. 1.6.0 Alpha May 11 from IPX and latest nightly. I can use the up/down arrows to navigate in the account view. Same results on Windows 7. Can't use keyboard to go from navigation panel to account view.

[whalley]

Looks like something really odd with my Mac, as rebooting and even using earlier versions of app still exhibit this issue. I'll close again as seems localised to my setup...

[vomikan]

Can't use keyboard to go from navigation panel to account view.

Possible solution is: