Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts Visible menu missing check mark to indicate which option is selected #3474

Closed
4 of 6 tasks
tactilis opened this issue May 20, 2021 · 4 comments
Closed
4 of 6 tasks
Assignees
Milestone

Comments

@tactilis
Copy link

MMEX version:

  • 1.6.0 Alpha.1
  • 1.5.1

Operating System:

  • Windows
  • Mac OSX Not tested
  • Linux Not tested

Description of the bug

The Accounts Visible menu is missing the check mark to show which of All, Favourites, Open, or Closed is currently selected.

Reproduction

Is the bug reproducible?

  • Always

Reproduction steps:

  1. In the Navigation tree, right click on Bank Accounts, Credit Card Accounts, Loan Accounts, Term Accounts, or Stock Portfolios
  2. Observe that the Accounts Visible sub-menu does not have a check mark to indicate which option is currently selected.

Here is a screenshot where All is currently selected:

image

Here is a screenshot where Open is currently selected:

image

Expected result:

The Accounts Visible sub-menu should have a check mark to indicate which option is currently selected.

Actual result:

No check mark on the sub menu.

Additional information

@tactilis
Copy link
Author

Which issue is this a duplicate of? I did search before raising it but couldn't find a prior issue covering this.

image

@vomikan vomikan removed the duplicate label May 21, 2021
@vomikan
Copy link
Member

vomikan commented May 21, 2021

#2635

@tactilis
Copy link
Author

tactilis commented May 21, 2021

OK.

However, that's not quite the same issue. In #2635, people were expecting the right-click Navigation | Accounts Visible setting to persist across runs of MMEX. My enhancement suggestion is not for that - just for a check mark to show which of the views is currently selected.

As someone mentioned in the discussion of #2635, Options | View also has an Accounts Visible setting.

I think most of the confusion could be avoided by changing the wording on the Options dialog to indicate that the setting there is applied at startup:

image

By the way, if you do make a change to the options dialog, then the 'ALL' choice in the dropdown ideally should be changed to 'All' to match the case of the other choices and the 'All' setting in the Navigation | Accounts Visible menu.

vomikan added a commit to vomikan/moneymanagerex that referenced this issue Jun 6, 2021
vomikan added a commit that referenced this issue Jun 6, 2021
fix(#3474): Accounts Visible menu missing check mark to indicate whic…
@vomikan vomikan self-assigned this Jun 6, 2021
@vomikan vomikan added the fixed label Jun 6, 2021
@vomikan vomikan closed this as completed Jun 6, 2021
@vomikan
Copy link
Member

vomikan commented Jun 6, 2021

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants