Cannot start: "bad locale name"

[Joker2k]

MMEX version:
git master

Operating System:

• Windows
• Mac OSX
• Linux

Description of the bug

Since a while I cannot start mmex on my win7 machine.

Reproduction

Is the bug reproducible?

• Always
• Randomly
• Happened only once

Reproduction steps:

1. From start's splash "Open last opened database"

…

Expected result:
Program starts

Actual result:
Program closes with error

Additional information

If you have a backtrace for a crash or a warning, paste it here.

[vomikan]

I recommend to clear the following field in mmb file using any SQLite Developer.

[vomikan]

Seems it should be added "try" before any locale usage into wxString Model_Currency::toString function.

    try {
        auto test = fmt::format(std::locale(locale.c_str()), "{:L}", 123);
    }
    catch (std::exception & ex) {
        locale = "";
    }

[Joker2k]

First thing i've checked, my:

Unfortunately I'm unable to debug on win7 PC. I don't have issue on my win10 dev machine.

Even starting new database from splash, I have that error. But program doesn't closes.

[vomikan]

Just clear LOCAL field (do not delete the line but only the value).

[Joker2k]

try/catch doesn't help
LOCALE field have "not null" constraint. Setting to " " doesn't help either
git master as for now doesn't resolve

[vomikan]

try/catch doesn't help
LOCALE field have "not null" constraint. Setting to " " doesn't help either
git master as for now doesn't resolve

It should help
"not null" does not metter. The fmt::format(std::locale(locale.c_str()), "{:L}", 123) function would call exception on any invalid locale value then locale became empty (does not used).

[Joker2k]

Last commit broke even my win10 machine...
You should uninit in catch:

Still win7 got "bad locale"....

[vomikan]

@Joker2k is it working now?

[Joker2k]

no, same "bad locale" on win7 preventing start from portable mode

Version: 1.5.3-Beta.1
• Build on Jun 12 2021 16:22:03
• Database version: 7 • (aes128cbc)
MMEX is using the following support products:
• wxWidgets 3.1.4 (wxMSW 6.1)
• wxSQLite3 4.6.0 (SQLite 3.31.1)
• RapidJSON 1.1.0
• Lua 5.3.5
• lunasvg v2.0.1
• libcurl/7.59.0 WinSSL zlib/1.2.8
• gettext 0.19.8.1
• apexcharts.js
Build using:
• CMake 3.20.21032501-MSVC_2
• MSBuild 16.10.1.27004
• Microsoft Visual Studio 16.0
• Microsoft Visual C++ 19.29.30037.0
• Windows SDK 10.0.18362.0
Running on:
• Windows 7 (build 7601, Service Pack 1), 64-bit edition
• Russian (windows-1251)
• 1920x1200 32bit 72x72ppi

[vomikan]

2)

3)

There is only one issue:

[Joker2k]

Yes, finally fixed...