Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on database creation 1.5.3 #3667

Closed
5 of 8 tasks
tayrayb opened this issue Jun 29, 2021 · 2 comments
Closed
5 of 8 tasks

Crash on database creation 1.5.3 #3667

tayrayb opened this issue Jun 29, 2021 · 2 comments
Assignees
Milestone

Comments

@tayrayb
Copy link

tayrayb commented Jun 29, 2021

MMEX version:

  • 1.5.x
  • 1.6.x

Note: bug reporters are expected to have verified the bug still exists
either in the last stable version of MMEX or on updated development code
(master branch).

Operating System:

  • Windows
  • Mac OSX
  • Linux

Description of the bug

Money Manager EX 1.5.3 crashes on making a new database, when setting the currency. This happens in both Linux and Windows.

Reproduction

Is the bug reproducible?

  • Always
  • Randomly
  • Happened only once

Reproduction steps:

  1. Create new database
  2. Set Currency
  3. CRASH!

Expected result:

Actual result:

Additional information

If you have a backtrace for a crash or a warning, paste it here.

report.tar.gz

@Dandy64
Copy link

Dandy64 commented Jun 29, 2021

I can confirm this problem. It was reproduced on Windows 10 on 2 laptops: Dell and Lenovo.

In addition, the version number is not correct - 1.52 instead of 1.53 at
[https://www.moneymanagerex.org/download]
But it was downloaded the correct version - 1.5.3.
image

@whalley
Copy link
Member

whalley commented Jun 29, 2021

Same on MacOS.

currencyID_ = Option::instance().getBaseCurrencyID();

From a quick scan , maybe related to this. Possibly need to just pick the first currency as no default exists yet?

UPDATE: Not quite that simple as the ToString called later in the currency dialog assumes that the the default currency exists.. Will need to look at this later today.

@vomikan vomikan added this to the v1.5.4 milestone Jun 29, 2021
@vomikan vomikan added bug good first issue good issue for first-time contributors - please fix me ASAP labels Jun 29, 2021
@whalley whalley self-assigned this Jun 29, 2021
@whalley whalley added the fixed label Jun 29, 2021
@vomikan vomikan removed the good first issue good issue for first-time contributors - please fix me ASAP label Jun 29, 2021
vomikan added a commit that referenced this issue Jun 29, 2021
fix(#3667): Handling when base curr not yet set
@vomikan vomikan closed this as completed Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants