Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to link a monthly budget to an annual budget #4214

Closed
BanCrash opened this issue Feb 17, 2022 · 14 comments
Closed

Option to link a monthly budget to an annual budget #4214

BanCrash opened this issue Feb 17, 2022 · 14 comments
Assignees
Milestone

Comments

@BanCrash
Copy link
Contributor

Come from #4165

Description of the feature

When you create a new monthly budget, would be very useful to have the option to "link" that monthly budget to an annual budget, so one change on one of them affects the other.

Example: You create a new estimation of a monthly expense of 100 € for parking category on the annual budget, then the monthly budget automatically gets updated with 100 € estimated on the same category.

The opposite should work too, if you edit the monthly budget with an estimation of a monthly expense, the annual budget should get automatically updated too.

Use cases

This would make more useful the budgets feature since currently annual and monthly budgets are working as different budgets. and with this they will be dependant of each other.

@vomikan
Copy link
Member

vomikan commented Feb 18, 2022

#4165

@vomikan
Copy link
Member

vomikan commented Feb 18, 2022

I think it will be a good improvement

@whalley whalley added this to the v1.5.21 milestone Sep 10, 2022
@whalley whalley self-assigned this Sep 10, 2022
@whalley
Copy link
Member

whalley commented Sep 10, 2022

I propose the following:

  • The existing 'Budget Setup' remains the same. You enter Yearly and Monthly budgets.
  • We introduce an option to specify how the yearly and monthly budgets estimates interact
    • MERGE (default) - The yearly and monthly budget estimates are combined, e.g. you can define an annual budget for a category but add (or subtract) more for certain months.
    • MONTH OVERRIDE - If a budget for a month is defined then it will override the yearly figure, e.g. you can define an annual budget for a category but change it for certain months.

In the 'Budget Performance' and 'Budget Category Summary' reports we only allow the Years to be specified - not sure why we need to monthly budgets to be selectable here. If no yearly budget estimate is setup, just monthly figures, then we can still present that year for selection.

Does that make sense? Any further suggestions.

@BanCrash
Copy link
Contributor Author

I propose the following:

* The existing 'Budget Setup' remains the same. You enter Yearly and Monthly budgets.

* We introduce an option to specify how the yearly and monthly budgets estimates interact
  
  * MERGE (default) - The yearly and monthly budget estimates are combined, e.g. you can define an annual budget for a category but add (or subtract) more for certain months.
  * MONTH OVERRIDE - If a budget for a month is defined then it will override the yearly figure, e.g. you can define an annual budget for a category but change it for certain months.

In the 'Budget Performance' and 'Budget Category Summary' reports we only allow the Years to be specified - not sure why we need to monthly budgets to be selectable here. If no yearly budget estimate is setup, just monthly figures, then we can still present that year for selection.

Does that make sense? Any further suggestions.

For me that would be just perfect 👍

whalley pushed a commit to whalley/moneymanagerex that referenced this issue Sep 13, 2022
@whalley
Copy link
Member

whalley commented Sep 13, 2022

Have added option:
CleanShot 2022-09-14 at 00 24 52
If checked then any monthly budget will override the yearly budget, otherwise the monthly budget will be added to the annual budget.

When selecting budgets in the budget reports only years can be specified. The report will merge yearly and monthly budgets based on the above option.
CleanShot 2022-09-14 at 00 26 39

whalley pushed a commit to whalley/moneymanagerex that referenced this issue Sep 13, 2022
@BanCrash
Copy link
Contributor Author

Have added option: CleanShot 2022-09-14 at 00 24 52 If checked then any monthly budget will override the yearly budget, otherwise the monthly budget will be added to the annual budget.

When selecting budgets in the budget reports only years can be specified. The report will merge yearly and monthly budgets based on the above option. CleanShot 2022-09-14 at 00 26 39

That's nice, thank you!

@whalley
Copy link
Member

whalley commented Sep 14, 2022

@BanCrash Would be good if you could test this Beta build and report back any issues.
https://ci.appveyor.com/api/buildjobs/jxdaxqbd9xdxq9sk/artifacts/mmex-1.5.21-Beta.1-win64.exe

@BanCrash
Copy link
Contributor Author

BanCrash commented Sep 14, 2022

@BanCrash Would be good if you could test this Beta build and report back any issues. https://ci.appveyor.com/api/buildjobs/jxdaxqbd9xdxq9sk/artifacts/mmex-1.5.21-Beta.1-win64.exe

@whalley I don't know if I'm doing something wrong, but I created a new budget on a test database and I can't get my monthly estimation on the yearly budget:

Budgets:
imagen

Monthly budget:
imagen

Year budget:
imagen

Settings:
imagen

I've tried with the setting enabled or disabled, but there is no difference on the behaviour.

imagen

@whalley
Copy link
Member

whalley commented Sep 14, 2022

As noted above...

The existing 'Budget Setup' remains the same. You enter Yearly and Monthly budgets.

The 'budget' is entered as yearly and/or monthly, it is only when creating the budget reports that the merge is done.

@BanCrash
Copy link
Contributor Author

BanCrash commented Sep 14, 2022

@whalley oh, sorry, I thought you mean with that that there wouldn't be difference while entering the data, not while showing it.

About the reports, the Budget perfomance report so far seems to work fine, but the Budget Category Summary if you have the setting enable it will ignore the data entered on the yearly budget:

Report:
imagen

Yearly budget:
imagen

I created 3 monthly budgets, two of them have 50 € as estimated quantity for that category, and the other have 500 €, so that's why I think it ignores the yearly budget.

EDIT: With the option disabled it works as expected, it will add the yearly budget value to the monthly budgets values, as expected:
imagen

(1200 € yearly + 500 € monthly 1 + 50 € monthly 2 + 50 € monthly 3).

whalley pushed a commit to whalley/moneymanagerex that referenced this issue Sep 14, 2022
@whalley
Copy link
Member

whalley commented Sep 14, 2022

About the reports, the Budget perfomance report so far seems to work fine, but the Budget Category Summary if you have the setting enable it will ignore the data entered on the yearly budget:

Hopefully now fixed.

@whalley oh, sorry, I thought you mean with that that there wouldn't be difference while entering the data, not while showing it.

I'm not sure what we can really present differently in the budget setup. Do you have a proposal?

@BanCrash
Copy link
Contributor Author

About the reports, the Budget perfomance report so far seems to work fine, but the Budget Category Summary if you have the setting enable it will ignore the data entered on the yearly budget:

Hopefully now fixed.

If there is a new link I can test it if you want.

@whalley oh, sorry, I thought you mean with that that there wouldn't be difference while entering the data, not while showing it.

I'm not sure what we can really present differently in the budget setup. Do you have a proposal?

My original idea was to show the same as it is being showed on the total column of the Budget perfomance report, so when you override a month it will get get added or substracted to the total quantity on the year. But to be honest your implementation is better than I thought on my original post and I think that now it doesn't have any sense to modify it.

whalley pushed a commit to whalley/moneymanagerex that referenced this issue Sep 14, 2022
whalley pushed a commit to whalley/moneymanagerex that referenced this issue Sep 14, 2022
@whalley
Copy link
Member

whalley commented Sep 14, 2022

Try this: https://ci.appveyor.com/api/buildjobs/cww80macvl2x9v7v/artifacts/mmex-1.5.21-Beta.1-win64.exe

@whalley whalley added the fixed label Sep 14, 2022
vomikan added a commit that referenced this issue Sep 14, 2022
@BanCrash
Copy link
Contributor Author

Try this: https://ci.appveyor.com/api/buildjobs/cww80macvl2x9v7v/artifacts/mmex-1.5.21-Beta.1-win64.exe

I will make more tests tomorrow but so far I didn't found any more issues. Great job, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants