Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters do not take into account transactions where the categories are split #4698

Closed
Dellyes opened this issue Jun 22, 2022 · 8 comments
Closed
Assignees
Milestone

Comments

@Dellyes
Copy link

Dellyes commented Jun 22, 2022

Dans la Liste des opérations le résultats des filtres ne tiennent pas compte des opérations où la catégorie a été répartie


Version: 1.5.15 64-bit
• Build: Juin 16 2022 09:13:44
• db 7 • (aes128cbc)
• git e7bb96c (2022-06-16)

Libs:
• wxWidgets 3.1.5 (wxMSW 10.0)
• wxSQLite3 4.6.0 (SQLite 3.31.1)
• RapidJSON 1.1.0
• Lua 5.3.5
• lunasvg v2.3.1
• libcurl/7.82.0-DEV Schannel
• gettext 0.19.8.1
• apexcharts.js

Build using:
• CMake 3.16.2
• MSBuild 15.9.21.664
• MSVS15.0
• MSVSC 19.16.27035.0
• Windows SDK 10.0.14393.0

OS:
• Windows 10 (build 19044), 64-bit edition
• French (windows-1252)
• 1360x768 32bit 96x96ppi
@tactilis
Copy link

The title says: "In the list of operations, the results of the filters do not take into account operations where the category has been distributed"

@Dellyes

  1. You will need to provide more information. The nature of the problem you are having is not clear.
    Please report bugs on this form https://github.com/moneymanagerex/moneymanagerex/issues/new/choose and provide the information requested.

@whalley
Copy link
Member

whalley commented Jun 22, 2022

There was an error with split transactions, that was fixed here: whalley@9a6b832

Can you try the latest beta build. https://moneymanagerex.org/docs/downloads/development/

#4662

@whalley whalley changed the title Liste des opérations Filters do not take into account transactions where the categories are split Jun 22, 2022
@vomikan vomikan closed this as completed Jun 23, 2022
@Dandy64
Copy link

Dandy64 commented Jul 31, 2022

Sorry, but the problem still exists.
Last version 1.5.18, Windows, Portable, 64 bit

Steps.

  1. Created a new DB with just 1 account - Bank
  2. Created 2 transactions:

1 transaction - 200:
image

2 Transaction 100+50 =150:
image

Total - 350:
image

  1. Created Transaction filter
    image

Expected result: 150 + 200 = 350
Actual result: 200
image

The split transaction was not taken into account.
p.s. All the transactions were reconciled.
p.s.1 If you need it, I can send the Test DB.

@vomikan vomikan added bug and removed duplicate labels Jul 31, 2022
@vomikan vomikan reopened this Jul 31, 2022
@vomikan vomikan added this to the v1.5.19 milestone Jul 31, 2022
@vomikan vomikan self-assigned this Jul 31, 2022
@whalley
Copy link
Member

whalley commented Jul 31, 2022

Adding
if (dlg.get()->mmIsCategorySubCatChecked()) value = value + ".*";

after:

const auto& value = catFilter ? dlg.get()->mmGetCategoryPattern() : "";

should possibly fix it (need to remove the const also)

vomikan added a commit to vomikan/moneymanagerex that referenced this issue Jul 31, 2022
vomikan added a commit that referenced this issue Jul 31, 2022
fix(#4698): split and Include all sub-categories
@vomikan
Copy link
Member

vomikan commented Jul 31, 2022

Adding if (dlg.get()->mmIsCategorySubCatChecked()) value = value + ".*";

after:

const auto& value = catFilter ? dlg.get()->mmGetCategoryPattern() : "";

should possibly fix it (need to remove the const also)

I think I did it in my own way.

@vomikan vomikan added the fixed label Jul 31, 2022
@vomikan vomikan modified the milestones: v1.5.20, v1.5.19 Jul 31, 2022
@vomikan vomikan closed this as completed Aug 8, 2022
@tauchmi
Copy link

tauchmi commented Jan 9, 2023

It seems with 1.6.2 (64 bit) this is again an issue. You can simulate it easily with a new database.

It only happens when I filter by a top category and select "Include all sub-categories".
test.zip

@vomikan vomikan reopened this Jan 9, 2023
@vomikan vomikan modified the milestones: v1.5.19, v1.6.3 Jan 9, 2023
n-stein added a commit to n-stein/moneymanagerex that referenced this issue Jan 9, 2023
@vomikan vomikan closed this as completed Jan 9, 2023
@n-stein
Copy link
Contributor

n-stein commented Jan 9, 2023

@vomikan I see this is closed again but I didn't see a fix. If it is already handled let me know and I'll close PR #5515.

vomikan added a commit that referenced this issue Jan 9, 2023
fix(#4698): txn filter for split categories
@vomikan
Copy link
Member

vomikan commented Jan 10, 2023

@vomikan I see this is closed again but I didn't see a fix. If it is already handled let me know and I'll close PR #5515.

Unfortunately, I got confused in this case. I saw your comment after that I closed the case.
If something went wrong, feel free to fix it.

@vomikan vomikan mentioned this issue Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants