Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: 1.5.17b Crash When Changing HTML Scale Factor #4786

Closed
2 of 6 tasks
2BeeOrNot opened this issue Jul 5, 2022 · 11 comments
Closed
2 of 6 tasks

macOS: 1.5.17b Crash When Changing HTML Scale Factor #4786

2BeeOrNot opened this issue Jul 5, 2022 · 11 comments
Assignees

Comments

@2BeeOrNot
Copy link

MMEX version:

  • 1.5.14
  • 1.5.15
  • [] 1.5.16
  • 1.5.17 Beta
  • Other (please specify)

Note: bug reporters are expected to have verified the bug still exists
either in the last stable version of MMEX or on updated development code
(master branch).

Operating System:

  • [] Windows
  • Mac OSX
  • Linux

Working back from current beta to first beta crash started with 07-01-2022 build. Immediately crashes with crash report screen then dies. Did not happen with first two builds. Noticed when I was looking at the nifty popup calendar for macOS users and noticed the too high toolbar height which also started with the 07-01-2022 build. Tried changing scale factor and icon sizes but all I got was a crash when changing scale factor.

Toolbar_1517_062922

Toolbar_1517b_070122

@whalley whalley added the bug label Jul 5, 2022
@whalley whalley self-assigned this Jul 5, 2022
@tactilis
Copy link

tactilis commented Jul 5, 2022

I am not able to reproduce the crash on Windows

whalley pushed a commit to whalley/moneymanagerex that referenced this issue Jul 5, 2022
@whalley
Copy link
Member

whalley commented Jul 5, 2022

@2BeeOrNot Good spot, @tactilis it is in a piece of code that handles a needed MacOS workaround. Inadvertently changed as part of this 5a1d693. Fixed now.

@whalley whalley added the fixed label Jul 5, 2022
whalley added a commit that referenced this issue Jul 5, 2022
fix(#4786): MacOS scale factor fix
@whalley
Copy link
Member

whalley commented Jul 5, 2022

@2BeeOrNot New MacOS beta uploaded https://mmex.ipx.co.uk/

@2BeeOrNot
Copy link
Author

No crash in today's beta build. Is there a reason the toolbar is so high? it started with the July 1st build. In the previous two beta builds it was not so high, like in 1.5.16.

@tactilis
Copy link

tactilis commented Jul 5, 2022

@2BeeOrNot Set the Toolbar Icon Size to Normal

image

@tactilis
Copy link

tactilis commented Jul 5, 2022

...although looking at the icons, they are the correct size but are displayed in a toolbar that is too tall.

Try setting the size to Small, exiting and restarting MMEX, then set to Normal, exit and restart.

Does that fix it?

@whalley
Copy link
Member

whalley commented Jul 5, 2022

Yes think @vomikan made some changes in this area around these settings and defaults. Just resetting fixed it.

@2BeeOrNot
Copy link
Author

Tried @tactilis suggestion above. Same results. Tried deleting mmexini.db3 and creating new database. Toolbar still too tall.

@vomikan
Copy link
Member

vomikan commented Jul 6, 2022

Yes think @vomikan made some changes in this area around these settings and defaults. Just resetting fixed it.

I did nothing regarding this.

@whalley
Copy link
Member

whalley commented Jul 6, 2022

Yes think @vomikan made some changes in this area around these settings and defaults. Just resetting fixed it.

I did nothing regarding this.

Oh, OK I'll do a bit of digging as something affect my toolbar height also and I needed to reselect the icon size.... Not a major issue but may annoy users...

@whalley
Copy link
Member

whalley commented Jul 6, 2022

I've found some oddity with respect to the window positioning that seems to cause the odd toolbar behaviour. I'll raise another issue for this as it will require further investigation and possibly referring to the wXWidgets dev team.

#4791

@whalley whalley closed this as completed Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants