-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1. Implement Theme Mode
= Auto
to select Light
/Dark
theme from operating system setting; 2. Rename Auto
to System
.
#5861
Comments
It would be helpful to know with which operating system and which MMEX version the error occurs. |
|
Auto
select Light
/Dark
Theme Mod
from operating system setting
Auto
select Light
/Dark
Theme Mod
from operating system settingTheme Mode
= Auto
to select Light
/Dark
theme from operating system setting
Correct, it is not yet implemented. Right now Auto == Light. |
Sorry, I need to be more specific here. It is implemented on macOS only. It is not implemented yet for Windows or Linux. |
Fixed for Linux. The exact same code works for Windows, but perhaps we should hold off on the Windows change until dark mode is improved on that platform. Thoughts? |
Should |
Something is better than nothing. Can the improvements please be applied? |
They already were. They were merged after the nightly build, so check the beta tomorrow. |
Is #5866 all that is needed to change |
Theme Mode
= Auto
to select Light
/Dark
theme from operating system settingTheme Mode
= Auto
to select Light
/Dark
theme from operating system setting; 2. Rename Auto
to System
.
I believe so. Everything is based on the index of the choices rather than the text strings themselves. As long as "System" remains the first option (index 0) it should work. |
Can you please merge? |
Can the theme please update if MMEX is opened and then the system theme is changed? Firefox does this if there are pointers in the Firefox code. Thank you |
Thank you
The text was updated successfully, but these errors were encountered: