Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Implement Theme Mode = Auto to select Light/Dark theme from operating system setting; 2. Rename Auto to System. #5861

Closed
ovari opened this issue Apr 25, 2023 · 14 comments
Labels
Milestone

Comments

@ovari
Copy link
Contributor

ovari commented Apr 25, 2023

  1. Set operating system to use dark theme.
  2. Open MMEX.
  3. Buttons in the top row could be better.
  4. Dashboard shows in light theme.

image

Thank you

@renato-mmex
Copy link

It would be helpful to know with which operating system and which MMEX version the error occurs.

@n-stein
Copy link
Contributor

n-stein commented Apr 26, 2023

MMEX doesn't currently auto-detect when the OS is in dark mode.

image

You have to manually switch to the dark theme using the theme manager (or view options) to get the white icons and the dark dashboard.

@vomikan vomikan added question theme Theme related labels Apr 26, 2023
@ovari
Copy link
Contributor Author

ovari commented Apr 26, 2023

Money Manager Ex
• Version: 1.6.4-Beta.4 64-bit
• Built on: Apr 24 2023 03:26:30
• Database version: 18 (aes128cbc)
MMEX is using the following support products:
• wxWidgets 3.1.7 (wxGTK 3.24)
• wxSQLite3 4.9.1 (SQLite 3.40.0)
• RapidJSON 1.1.0
• Lua 5.3.6
• libcurl/7.81.0 OpenSSL/3.0.2 zlib/1.2.11 brotli/1.0.9 zstd/1.4.8 libidn2/2.3.2 libpsl/0.21.0 (+libidn2/2.3.2) libssh/0.9.6/openssl/zlib nghttp2/1.43.0 librtmp/2.3 OpenLDAP/2.5.14
• gettext 0.21
• apexcharts.js
Built with:
• CMake 3.22.1
• GNU Make 4.3
• GCC 11.2.0
Running on:
• Ubuntu.22.04.jammy
• Linux Mint 21.1 "vera"
• Linux 5.19.0-41-generic x86_64
• (UTF-8)
• 0x0 0bit 192x192ppi

@ovari
Copy link
Contributor Author

ovari commented Apr 26, 2023

@n-stein does that mean that Theme Mode = Auto, shown in the image below, is not yet implemented?

image

@vomikan should the question label be removed?

Thank you

@ovari ovari changed the title Dark theme Auto select Light/Dark theme from operating system setting Apr 26, 2023
@ovari ovari changed the title Auto select Light/Dark theme from operating system setting Auto select Light/Dark Theme Mod from operating system setting Apr 26, 2023
@ovari ovari changed the title Auto select Light/Dark Theme Mod from operating system setting Implement Theme Mode = Auto to select Light/Dark theme from operating system setting Apr 26, 2023
@n-stein
Copy link
Contributor

n-stein commented Apr 26, 2023

does that mean that Theme Mode = Auto, shown in the image below, is not yet implemented?

Correct, it is not yet implemented. Right now Auto == Light.

@n-stein
Copy link
Contributor

n-stein commented Apr 27, 2023

Correct, it is not yet implemented. Right now Auto == Light.

Sorry, I need to be more specific here. It is implemented on macOS only. It is not implemented yet for Windows or Linux.

n-stein added a commit to n-stein/moneymanagerex that referenced this issue Apr 27, 2023
@n-stein
Copy link
Contributor

n-stein commented Apr 27, 2023

Fixed for Linux.

The exact same code works for Windows, but perhaps we should hold off on the Windows change until dark mode is improved on that platform. Thoughts?

@vomikan vomikan added the solution found workaround or user side solution avaiable label Apr 27, 2023
@vomikan vomikan added this to the v1.6.5 milestone Apr 27, 2023
vomikan added a commit that referenced this issue Apr 27, 2023
@ovari
Copy link
Contributor Author

ovari commented Apr 27, 2023

Should Auto be changed to System?

@ovari
Copy link
Contributor Author

ovari commented Apr 27, 2023

The exact same code works for Windows, but perhaps we should hold off on the Windows change until dark mode is improved on that platform. Thoughts?

Something is better than nothing. Can the improvements please be applied?

@n-stein
Copy link
Contributor

n-stein commented Apr 27, 2023

Can the improvements please be applied?

They already were. They were merged after the nightly build, so check the beta tomorrow.

@ovari
Copy link
Contributor Author

ovari commented Apr 27, 2023

Is #5866 all that is needed to change Auto to System?

@ovari ovari changed the title Implement Theme Mode = Auto to select Light/Dark theme from operating system setting 1. Implement Theme Mode = Auto to select Light/Dark theme from operating system setting; 2. Rename Auto to System. Apr 27, 2023
@n-stein
Copy link
Contributor

n-stein commented Apr 27, 2023

Is #5866 all that is needed to change Auto to System?

I believe so. Everything is based on the index of the choices rather than the text strings themselves. As long as "System" remains the first option (index 0) it should work.

@ovari
Copy link
Contributor Author

ovari commented Apr 27, 2023

Is #5866 all that is needed to change Auto to System?

I believe so. Everything is based on the index of the choices rather than the text strings themselves. As long as "System" remains the first option (index 0) it should work.

Can you please merge?

@vomikan vomikan modified the milestones: v1.6.5, v1.6.4 Apr 28, 2023
@vomikan vomikan removed the solution found workaround or user side solution avaiable label Apr 28, 2023
@vomikan vomikan added the fixed label Apr 28, 2023
@vomikan vomikan closed this as completed May 11, 2023
@ovari
Copy link
Contributor Author

ovari commented May 11, 2023

Can the theme please update if MMEX is opened and then the system theme is changed?

Firefox does this if there are pointers in the Firefox code.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants