-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have Flathub as the sole distribution mechanism for MMEX on Linux #6246
Comments
@joshua-stone I added
|
@whalley Looks like the build made a bit of progress. Can you modify this line at the bottom from |
Much better! It looks like
|
Just fails on the final artifact copy now. Do you know where the |
So close now! You may have to try searching for it within the container, such adding this right after
|
Can you test the the build artifact works: https://app.circleci.com/pipelines/github/whalley/circleci-test/146/workflows/8b0eff8c-9f53-4d80-a734-d404ed074a25/jobs/176/artifacts |
Looks like it installs and runs:
You can probably test the installation process by attempting to install the .flatpak bundle inside the container:
And then have a unique version string for the build artifact:
|
Unfortunately, the following CI run won't succeed because it needs |
Yes, just noticed. Will it work anyway as flatpack is only availabel in the container. Would we need to install flatpack in the VM or generate the correct version info in the container? |
@whalley I think it would be best to try to install it within the container as part of the build for more complete coverage. VMs shouldn't be necessary either since the container already has flatpaks installed:
Can you see if either of these lines work?
|
The first seems to work. How do you propose getting the build/commit into the filename? I guess you could rename the mmex.flatpack in the container prior to it being copied to the asset directory. |
Maybe add something like this?
|
But I think the /tmp/artifacts is outside the container and not mounted as a visible filesystem. Was thinking more about just renaming as last action in container, but not sure git commit is visible there (though other builds do not include commit in name so not a deal breaker). That's what other Linux builds did in the past. |
You could skip adding a git commit hash to the filename for now and instead make it a feature for a follow-up feature request for when we can refine the CI. Can you see if this works?
|
Guess we could rename to include the commit as part of the file copy to /tmp/artifacts outside the VM. Adding in the |
That sounds feasible. Maybe have it as part of a bulk-renaming step so that all artifacts (Windows, macOS, Linux, etc) match a certain format? |
Don't think rename worked... Will have a look tommorow if it's a typo on my part. |
TBH I think it'd be better to turn this into a script because all of these inline commands are hard to follow and not very flexible. |
Can you see what running |
Output is:
Actually the version number you are using is wrong, you seem to be getting it from the latest published release and not from the versioning in CMakeLists.txt. It should be "1.7.0-Beta.1" |
It's actually correct insofar that it's using Even if you generated a file like |
Understood, but I feel we should be generating the org.moneymanagerex.MMEX.metainfo.xml file. It feels wrong and error prone to manually maintain this. |
Agreed. We can make this process easier by maintaining a NEWS file that combines with the metainfo file: It should also be trivial to have the buildsystem extract the version string with something like |
Will beta versions still be downloadable at https://app.circleci.com/pipelines/github/moneymanagerex/moneymanagerex ? |
Yes they will be, the intention is to have the flatpak available here. |
I presume the correct version (1.7.0-Beta.1) is visible inside the About menu in MMEX when run? If so, then I suggest we go with the |
fix(#6246): CircleCI just builds flatpak now
@whalley can you explain to me what is now the advantage of this solution?... |
MMEX versions for GNU/Linux from Flathub will be listed the Update Manager so that users can more easily see and install the latest version. Not sure whether or not the development versions will be available. |
@ovari This refers to Linux and on which distri does this work, all ? |
Steps to install GNU/Linux development version of MMEX
|
@ovari @whalley @joshua-stone |
Are we happy have Flathub as the sole distribution mechanism for MMEX on Linux, and remove the other Linux builds we make via CircleCI. I'm concious that the CircleCI builds are still on wx3.1.7 and are falling behind Linux OS release versions with no active maintenance.
Look to include Flatpak build as part of CI and drop other LInux support.
Originally posted by @whalley in #5989 (comment)
The text was updated successfully, but these errors were encountered: