Transaction Report - Wrong Field(s) Become Hidden Due to Tags/Rate Column Indices

[rmelillo76]

MMEX version:

• 1.7.0

Description of the bug

The inception of Tags and/or Rates may cause the wrong field(s) to be hidden on existing Transaction Reports that have hidden columns. Note: This is easy to correct on a report-by-report basis upon opening the report, but may cause confusion and frustration for users. If this can't be easily solved via logic or a SQL script, we may want to note this as a known issue when releasing 1.7.

Reproduction

Open a Transaction Report that was created prior to the inception of Rate and/or Tags that contains hidden field(s). In my case, I had hidden the "Rate" field. but now "Amount" erroneously becomes hidden. This appears to be because the fields are identified via index, and the index has changed due to the new Tags field.

Report opened in 1.63. The Notes field is hidden so the last column displayed is Amount:

I then opened the same database in 1.7 (after being upgraded to DB version 19) and viewed the report. The Amount field is now hidden instead and the Rate and Notes fields are displayed.

Thoughts?

[n-stein]

Good catch, Rich. I think I added Tags in the middle to make the order of fields in the "Hide Columns" pop-up match the filter dialog and didn't consider the implications of changing the item indices.

The easiest solution is to simply move Tags and Rate to the bottom of the list to preserve the index of all the pre-existing items, but that means those check boxes will now be at the end after the custom fields. Not ideal, but better than breaking saved reports.

Side note, we should consider changing the filter description to use the actual column heading rather than the index. I can't imagine "Hide Columns: 10" means much to anyone...

[n-stein]

A consideration -- moving "Rate" to the bottom would fix the pre-1.6.4 reports with any hidden columns that have index ≥10, but will throw off any reports saved in 1.6.4 where Rate is now expected to be at index 10.

[rmelillo76]

A consideration -- moving "Rate" to the bottom would fix the pre-1.6.4 reports with any hidden columns that have index ≥10, but will throw off any reports saved in 1.6.4 where Rate is now expected to be at index 10.

Thanks Nick. I think that's the way to handle this too. It's possible not too many users bother to hide columns, so the impact to existing reports since 1.6.4 may be low anyway. And in a future change we consider a change to show the true name rather than the index (e..g. "10") like you mentioned.

[n-stein]

On a related note, I noticed that the list of column names is not translated.

I assume this is unintentional and will fix.

[n-stein]

Fixed, also changed the report text to show column names instead of indices.

[rmelillo76]

Fixed, also changed the report text to show column names instead of indices.

Thanks! Code looks good, but for some reason the build failed in Appveyor, looks like ther was a git issue. So, I'll test once we have a successful build: https://ci.appveyor.com/project/whalley/moneymanagerex/builds/48431811/job/3lr5il7uhsatvlf3

[n-stein]

I'll test once we have a successful build

Should be able to test now using the latest build.

[rmelillo76]

Looks good, closing - thanks @n-stein !