Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations are not shown for strings which include the char → #6614

Closed
n-stein opened this issue Mar 26, 2024 Discussed in #6600 · 3 comments
Closed

Translations are not shown for strings which include the char → #6614

n-stein opened this issue Mar 26, 2024 Discussed in #6600 · 3 comments
Assignees
@n-stein
Labels
bug fixed i18n internationalization and localization
Milestone
v1.8.0

Comments

@n-stein
Copy link
Contributor

n-stein commented Mar 26, 2024

Discussed in #6600

Originally posted by DevelopmentAnything March 21, 2024
image

image

When I register share account, a message box appears, and the contents are empty.
I have completed all related translations.

why empty ? ? ?
@n-stein
Copy link
Contributor Author

n-stein commented Mar 26, 2024 •
edited

wxString::FromUTF8() needs to be wrapped in wxGetTranslation()

example from Help > Report a Bug

image

After applying wxGetTranslation:

image

and from the message box when creating a "Share" account:

image

n-stein added a commit to n-stein/moneymanagerex that referenced this issue Mar 26, 2024
@n-stein
fix(moneymanagerex#6614): fix translation of FromUTF8 strings
2fa3c86
@n-stein n-stein self-assigned this Mar 26, 2024
@n-stein n-stein added the bug label Mar 26, 2024
@n-stein
Copy link
Contributor Author

n-stein commented Mar 26, 2024

@DevelopmentAnything I can now see the message box translated:

image

can you check the beta build to see if your "blank" issue is resolved?

https://ci.appveyor.com/project/moneymanagerex/moneymanagerex/builds/49489119/job/r2sx0rmq5qu1kfdt/artifacts

@n-stein n-stein mentioned this issue Mar 26, 2024
Closed
@n-stein n-stein added the i18n internationalization and localization label Mar 26, 2024
@DevelopmentAnything
Copy link
Contributor

image

GOOD.

vomikan added a commit that referenced this issue Mar 27, 2024
@vomikan
Merge pull request #6615 from n-stein/fix(#6614)
3f3f081 
fix(#6614): fix translation of FromUTF8 strings
@n-stein n-stein added this to the v1.7.1 milestone Mar 27, 2024
@n-stein n-stein added the fixed label Mar 27, 2024
n-stein added a commit to n-stein/moneymanagerex that referenced this issue Mar 27, 2024
@n-stein
fix(moneymanagerex#6614): fix translation of FromUTF8 strings
6f910f0
@n-stein n-stein closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n-stein n-stein

Labels
bug fixed i18n internationalization and localization
Projects
None yet
Milestone
v1.8.0
Development

No branches or pull requests
2 participants
@n-stein @DevelopmentAnything