Undefined Index "digits" (#430)

* add test for handling parsing of invalid inputs * add failing test case for invalid input * check digits were found in regex
moneyphp · Dec 11, 2017 · 57d415a · 57d415a
1 parent 27f8dd6
commit 57d415a
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/src/Parser/DecimalMoneyParser.php b/src/Parser/DecimalMoneyParser.php
@@ -64,7 +64,7 @@ public function parse($money, $forceCurrency = null)
 
         $subunit = $this->currencies->subunitFor($currency);
 
-        if (!preg_match(self::DECIMAL_PATTERN, $decimal, $matches)) {
+        if (!preg_match(self::DECIMAL_PATTERN, $decimal, $matches) || !isset($matches['digits'])) {
             throw new ParserException(sprintf(
                 'Cannot parse "%s" to Money.',
                 $decimal

diff --git a/tests/Parser/DecimalMoneyParserTest.php b/tests/Parser/DecimalMoneyParserTest.php
@@ -82,4 +82,30 @@ public static function formattedMoneyExamples()
             ['-9.99', 'USD', 2, -999],
         ];
     }
+
+    public static function invalidMoneyExamples()
+    {
+        return [
+            ['INVALID'],
+            ['.'],
+        ];
+    }
+
+    /**
+     * @dataProvider invalidMoneyExamples
+     * @expectedException \Money\Exception\ParserException
+     */
+    public function testInvalidInputsThrowParseException($input)
+    {
+        $currencies = $this->prophesize(Currencies::class);
+
+        $currencies->subunitFor(Argument::allOf(
+            Argument::type(Currency::class),
+            Argument::which('getCode', 'USD')
+        ))->willReturn(2);
+
+        $parser = new DecimalMoneyParser($currencies->reveal());
+
+        $parser->parse($input, 'USD')->getAmount();
+    }
 }