Converter float precision (#445)

* handle large conversion ratios * increase precision * fix docblock
moneyphp · Jan 19, 2018 · fbf11e9 · fbf11e9
1 parent dd80a67
commit fbf11e9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Number.php b/src/Number.php
@@ -117,15 +117,15 @@ public static function fromString($number)
     /**
      * @param float $floatingPoint
      *
-     * @return Number
+     * @return self
      */
     public static function fromFloat($floatingPoint)
     {
         if (is_float($floatingPoint) === false) {
             throw new \InvalidArgumentException('Floating point expected');
         }
 
-        return self::fromString(sprintf('%.8F', $floatingPoint));
+        return self::fromString(sprintf('%.14F', $floatingPoint));
     }
 
     /**

diff --git a/tests/ConverterTest.php b/tests/ConverterTest.php
@@ -89,6 +89,8 @@ public function convertExamples()
             ['XBT', 'USD', 8, 2, 6597, 10, 0],
             ['XBT', 'USD', 8, 2, 6597, 100, 1],
             ['ETH', 'EUR', 18, 2, 330.84, '100000000000000000', 3308],
+            ['BTC', 'USD', 8, 2, 13500, 100000000, 1350000],
+            ['USD', 'BTC', 2, 8, 1 / 13500, 1350000, 100000000],
         ];
     }
 }