Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.2 #715

Closed
wants to merge 4 commits into from
Closed

Support PHP 8.2 #715

wants to merge 4 commits into from

Conversation

rvanlaak
Copy link

@rvanlaak rvanlaak commented Sep 29, 2022

Seems PHP 8.2 is supported without having to make any changes.

phpspec is not supporting 8.2 yet, but work is in progress. This is blocking us from adding php 8.2 support for now with the current set of requirements.

@rvanlaak rvanlaak closed this Sep 29, 2022
@rvanlaak
Copy link
Author

Closing for now. Wanted to work on this on my own fork first.

@rvanlaak rvanlaak reopened this Sep 29, 2022
@rvanlaak
Copy link
Author

phpspec is not supporting 8.2 yet, but phpspec/phpspec#1435. This is blocking us from adding PHP 8.2 support for now with the current set of requirements.

image

@evertharmeling
Copy link

With PHP 8.2 now released, it would be nice to have this merged and available :)

@mattvb91
Copy link

any chance of getting this in?

@rvanlaak rvanlaak marked this pull request as ready for review December 10, 2022 10:27
@rvanlaak
Copy link
Author

Marked PR as ready for review. CI pipeline run requires maintainer approval.

@ruudk
Copy link
Contributor

ruudk commented Dec 12, 2022

@frederikbosch Would you mind approving the workflow so that we can see if it's mergable? Thanks 🙏

@shouze
Copy link

shouze commented Dec 12, 2022

Looks like because of phpspec & prophecy, need to add --ignore-platform-req=php to composer install, at least during time of those dependencies upgrade.

@frederikbosch
Copy link
Member

The current CI / Docs error is fixed in master.

@rogervila
Copy link
Contributor

PHPSpec 8.2 support is merged but not yet released (see phpspec/phpspec#1434)

@rvanlaak you will have to re-run CI once it is available.

@rogervila
Copy link
Contributor

I fixed PHPSpec CI issues here phpspec/phpspec#1437
I will comment here once a new version is available

@rogervila
Copy link
Contributor

@rvanlaak PHPSpec 7.3.0 is available! Could you re-run CI steps for PHP 8.2?

@rogervila
Copy link
Contributor

Hi @frederikbosch, could you re-run the CI steps for PHP 8.2, since its dependencies have been already upgraded?
Thank you!

@rogervila
Copy link
Contributor

rogervila commented Dec 15, 2022

Wait, why is there a composer.lock file on the package?
@frederikbosch is there any reason to have it? Usually, packages do not contain lock files.
@rvanlaak could you please remove it?

Update: Could we merge #722 first?

@rogervila rogervila mentioned this pull request Dec 15, 2022
@frederikbosch
Copy link
Member

I believe this was chosen because we were also applying mutation testing, and were planning to use dependabot. See this PR. But, feel free to remove it. I am not against that. I never commit composer.lock in other libs.

@frederikbosch
Copy link
Member

You can cherry pick the last two commits - fix docs and remove composer.lock - from master into this branch to see if CI succeeds now.

@rogervila
Copy link
Contributor

Thank you @frederikbosch
I have seen some psalm errors on master. I am opening another PR to fix them.

@frederikbosch
Copy link
Member

Great, I was also preparing to do that, but please go ahead.

@frederikbosch frederikbosch mentioned this pull request Dec 15, 2022
@frederikbosch
Copy link
Member

See #724

@frederikbosch
Copy link
Member

Thanks for all your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants