-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Follow device brightness #12
Comments
Player follows system volume. I agree that the initial brightness level would be better the same as current system one. However I intentionally want manual brightness only and not to complicate things with settings for that (to prefer system brightness). |
@moneytoo I don't really care about the brightness being manual or not, after all I think having this control over brightness in an affordable way is quite useful for most people. Can the app control the system's own brightness rather than being separated is a viable alternative? I really don't know, but I believe you'll choose the best way. |
I'm not sure if changing system brightness is possible (at least not without permission) - and definitely not expected. This player has its own brightness, just like MX Player - it also has its own brightness which it saves and restores (at least this is the default). |
@moneytoo Got it. So, unless you want to look for a way to make the initial brightness follow the system level even with the manual brightness setting I think this issue can be closed. Anyway this is not very important so you can see it calmly later. |
I will try setting the initial brightness. I already have one function for it prepared. |
@moneytoo Thank you so much! |
I'm afraid that it's not possible to detect current system brightness to use it as initial value for the manual control within the Player app. MX Player also isn't able to do that and uses its own initial brightness. |
@moneytoo Actually, in the case of MX Player, it has the options of controlling the brightness of the system (in this option the brightness is always equal to that selected in the system) or control the brightness manually. But no problem, thanks anyway. |
It would be possible to use system brightness just until user starts manually controlling it (like NewPipe does)... But it would be too much code for such such a feature I don't really want to support. |
@moneytoo Got it. |
Describe the feature
It's not very good to open the app and be greeted by a much higher brightness than the one set up on your device, so it would be great for the app to follow the brightness of the device. In fact the ideal would be an option to enable/disable manual brightness control in the app, but the default would be to follow the brightness of the system.
Describe the solution you'd like
1. [Added in v0.12 (910c4ed)]
Follow the system brightness when opening the app.2. [Will not be added]
Option to turn off brightness and volume gestures.Note: Thank you so much for your great work, I finally found a simple, lightweight and efficient video player. Your app is actually very good.
The text was updated successfully, but these errors were encountered: