Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos from Huawei Gallery won't play #7

Closed
ThracianKnight1907 opened this issue Dec 19, 2020 · 4 comments
Closed

Videos from Huawei Gallery won't play #7

ThracianKnight1907 opened this issue Dec 19, 2020 · 4 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@ThracianKnight1907
Copy link

Hello,

I'd like to report a possible bug. I'm trying to use this app as the default video player on my phone, but if i try to play a file from the Gallery, the player will open, but nothing would actually play. Oddly, if i open the same videos from file manager it works ok. I'm running android 10, and my phone model is Huawei P20 Pro.

@moneytoo moneytoo added the bug Something isn't working label Dec 19, 2020
@moneytoo
Copy link
Owner

Hi. Could you try opening "App info" detail for Just Player (the screen from where you uninstall an app or clear its data) and grant it Storage permission? Does it work then?

@ThracianKnight1907
Copy link
Author

This fixed my issue, thanks. However I don't believe it prompted me for this permission when I first installed it.

@moneytoo
Copy link
Owner

Yes, the player app currently doesn't ask for this storage permission. It shouldn't be needed when interacting with other modern and properly written apps (at least from Android 7 and up). System apps are excluded from the requirements to target higher Android versions. I planning on adding the prompt for the storage permission eventually (when opening from these "unsupported" apps).

moneytoo added a commit that referenced this issue Jan 30, 2021
@moneytoo moneytoo added the wontfix This will not be worked on label Feb 8, 2021
@moneytoo
Copy link
Owner

moneytoo commented Feb 8, 2021

I hope I will be able to maintain this app over time so I focus on the actually maintainable and "testable" feature set. Support for these kind of hacks - receiving apps need storage permission when it's actually the task for the sender app - is fortunately needed less and less and eventually going fully away with latest Android releases. I even removed the storage access permission from the latest versions. This player really tries to go to the extreme.

(Still, you can continue using the -online build from Github that can be manually given the storage permission.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants